Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another YAML fix #5596

Merged

Conversation

davidmirror-ops
Copy link
Contributor

Tracking issue

Why are the changes needed?

Me again, the fix introduced another problem. It should be the last

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: davidmirror-ops <[email protected]>
@davidmirror-ops davidmirror-ops merged commit d6da838 into flyteorg:master Jul 26, 2024
43 of 44 checks passed
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: David Espejo <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.89%. Comparing base (9d0d67a) to head (501a35b).
Report is 123 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5596      +/-   ##
==========================================
- Coverage   35.90%   35.89%   -0.02%     
==========================================
  Files        1301     1301              
  Lines      109419   109419              
==========================================
- Hits        39287    39276      -11     
- Misses      66035    66045      +10     
- Partials     4097     4098       +1     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 53.70% <ø> (-0.04%) ⬇️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.28% <ø> (ø)
unittests-flyteidl 7.09% <ø> (ø)
unittests-flyteplugins 53.31% <ø> (ø)
unittests-flytepropeller 41.73% <ø> (-0.02%) ⬇️
unittests-flytestdlib 55.25% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant